Python package #1
Conversation
voa/copula.py
Outdated
| @@ -26,23 +28,25 @@ def create_Q_grid(n=10): | |||
|
|
|||
| return grid | |||
|
|
|||
|
|
|||
| @numba.njit(parallel=True) | |||
| def calculate_copula_part(t, c): | |||
There was a problem hiding this comment.
Please type function signature, and use more verbose parameter names
There was a problem hiding this comment.
I added the signatures. The names are kept according to the paper and the initial implementation. We can change it, but I think it will not make the code more readable as someone will need to "translate" the names from our code to the equations from original c# implementation.
voa/copula.py
Outdated
| c[i, j] = c[0, j] + n_inv * np.sum(j >= t[:i]) | ||
| return c | ||
|
|
||
|
|
||
| @numba.njit | ||
| def wn(n, c, i, j): |
There was a problem hiding this comment.
I can maybe accept very short parameter names, but please name function verbosely.
There was a problem hiding this comment.
The same as above applies here. The name wn come from the paper. We can change all the names, but the question is if we should. @mp360288 wdyt?
There was a problem hiding this comment.
makes sense then if it comes from paper. For readability imo you can do two things:
- add docstring
- differentiate between public and private API - I guess this
wnfunction will never be called by user?
Hejka, zrobiłem (?) refactor kodu, tak, żeby zrobić z tego pakiet do pythona. Wszystkie pomysły i uwagi mile widziane.